linux-kernel - Re: [PATCH -next v2 1/2] ext4: remove unnecessary drop path references in mext_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 10:15:21 +0200
From:   Jan Kara <jack@...e.cz>
To:     Ye Bin <yebin10@...wei.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        jack@...e.cz
Subject: Re: [PATCH -next v2 1/2] ext4: remove unnecessary drop path
 references in mext_check_coverage()

On Sat 24-09-22 10:12:10, Ye Bin wrote:
> According to Jan Kara's suggestion:
> "The use in mext_check_coverage() can be actually removed
> - get_ext_path() -> ext4_find_extent() takes care of dropping the references."
> So remove unnecessary call ext4_ext_drop_refs() in mext_check_coverage().
> 
> Signed-off-by: Ye Bin <yebin10@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/move_extent.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
> index 701f1d6a217f..782bbda2a717 100644
> --- a/fs/ext4/move_extent.c
> +++ b/fs/ext4/move_extent.c
> @@ -103,7 +103,6 @@ mext_check_coverage(struct inode *inode, ext4_lblk_t from, ext4_lblk_t count,
>  		if (unwritten != ext4_ext_is_unwritten(ext))
>  			goto out;
>  		from += ext4_ext_get_actual_len(ext);
> -		ext4_ext_drop_refs(path);
>  	}
>  	ret = 1;
>  out:
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR