linux-kernel - Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07e63329-b3b7-736e-1de3-625af5c4541f@linaro.org>
Date:   Mon, 26 Sep 2022 10:19:32 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Luca Weiss <luca@...tu.xyz>, linux-arm-msm@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: pmx65: use node name "gpio" for spmi-gpio

On 25/09/2022 21:06, Luca Weiss wrote:
> All other usages of qcom,spmi-gpio use the gpio@ node name, and this is
> also validated by the dt binding check. Fix it.
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
>   arch/arm/boot/dts/qcom-pmx65.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-pmx65.dtsi b/arch/arm/boot/dts/qcom-pmx65.dtsi
> index abf229a8b75a..1c7fdf59c1f5 100644
> --- a/arch/arm/boot/dts/qcom-pmx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-pmx65.dtsi
> @@ -20,7 +20,7 @@ pmx65_temp: temp-alarm@a00 {
>   			#thermal-sensor-cells = <0>;
>   		};
>   
> -		pmx65_gpios: pinctrl@...0 {
> +		pmx65_gpios: gpio@...0 {
>   			compatible = "qcom,pmx65-gpio", "qcom,spmi-gpio";
>   			reg = <0x8800>;
>   			gpio-controller;

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>