linux-kernel - Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0f42da0-c302-dd95-8fd7-95f125a9d4f2@linaro.org>
Date:   Mon, 26 Sep 2022 10:50:57 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Luca Weiss <luca@...tu.xyz>, linux-arm-msm@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: msm8974-sony-*: fix multi-led node name

On 25/09/2022 19:56, Luca Weiss wrote:
> The name rgb-led is not allowed, multi-led is supposed to be used.
> 
> <snip>/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine-amami.dtb: pm8941@1: pwm: 'rgb-led' does not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
>          From schema: <snip>/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
>   arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi           | 2 +-
>   .../arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> index 5a70683d9103..c1d97190ea71 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi
> @@ -178,7 +178,7 @@ &pm8941_lpg {
>   
>   	qcom,power-source = <1>;
>   
> -	rgb-led {
> +	multi-led {
>   		color = <LED_COLOR_ID_RGB>;
>   		function = LED_FUNCTION_STATUS;
>   
> diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> index 85348562e861..94daa1a3240a 100644
> --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts
> @@ -295,7 +295,7 @@ &pm8941_lpg {
>   
>   	qcom,power-source = <1>;
>   
> -	rgb-led {
> +	multi-led {
>   		color = <LED_COLOR_ID_RGB>;
>   		function = LED_FUNCTION_STATUS;
>   

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>