[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2b57b492-8765-8629-1c94-ea04c0188792@linaro.org>
Date: Mon, 26 Sep 2022 10:56:08 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Luca Weiss <luca@...tu.xyz>, linux-arm-msm@...r.kernel.org
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: qcom: pm8941: adjust node names to bindings
Hi,
On 25/09/2022 23:02, Luca Weiss wrote:
> pm8941-misc should be called 'extcon' and pm8941-coincell 'charger'.
>
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
> arch/arm/boot/dts/qcom-pm8941.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-pm8941.dtsi b/arch/arm/boot/dts/qcom-pm8941.dtsi
> index 33517cccee01..01f14d5f314d 100644
> --- a/arch/arm/boot/dts/qcom-pm8941.dtsi
> +++ b/arch/arm/boot/dts/qcom-pm8941.dtsi
> @@ -27,7 +27,7 @@ pwrkey@800 {
> bias-pull-up;
> };
>
> - usb_id: misc@900 {
> + usb_id: extcon@900 {
> compatible = "qcom,pm8941-misc";
> reg = <0x900>;
> interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
> @@ -138,7 +138,7 @@ pm8941_iadc: adc@...0 {
> qcom,external-resistor-micro-ohms = <10000>;
> };
>
> - pm8941_coincell: coincell@...0 {
> + pm8941_coincell: charger@...0 {
> compatible = "qcom,pm8941-coincell";
> reg = <0x2800>;
> status = "disabled";
I think those changes are unrelated and should be split into 2 patches.
Neil
Powered by blists - more mailing lists