linux-kernel - Re: [PATCH v2 2/3] s390/pci: remove unused bus_next field from struct zpci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 26 Sep 2022 11:17:34 +0200
From:   Pierre Morel <pmorel@...ux.ibm.com>
To:     Niklas Schnelle <schnelle@...ux.ibm.com>,
        Matthew Rosato <mjrosato@...ux.ibm.com>, iommu@...ts.linux.dev
Cc:     linux-s390@...r.kernel.org, borntraeger@...ux.ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com, agordeev@...ux.ibm.com,
        svens@...ux.ibm.com, joro@...tes.org, will@...nel.org,
        robin.murphy@....com, jgg@...dia.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] s390/pci: remove unused bus_next field from struct
 zpci_dev



On 9/22/22 11:52, Niklas Schnelle wrote:
> This field was added in commit 44510d6fa0c0 ("s390/pci: Handling
> multifunctions") but is an unused remnant of an earlier version where
> the devices on the virtual bus were connected in a linked list instead
> of a fixed 256 entry array of pointers.
> 
> It is also not used for the list of busses as that is threaded through
> struct zpci_bus not through struct zpci_dev.
> 
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>

Reviewed-by: Pierre Morel <pmorel@...ux.ibm.com>


> ---
>   arch/s390/include/asm/pci.h | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
> index 7b4cdadbc023..108e732d7b14 100644
> --- a/arch/s390/include/asm/pci.h
> +++ b/arch/s390/include/asm/pci.h
> @@ -117,7 +117,6 @@ struct zpci_bus {
>   struct zpci_dev {
>   	struct zpci_bus *zbus;
>   	struct list_head entry;		/* list of all zpci_devices, needed for hotplug, etc. */
> -	struct list_head bus_next;
>   	struct kref kref;
>   	struct hotplug_slot hotplug_slot;
>   

-- 
Pierre Morel
IBM Lab Boeblingen