lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <87sfke32pc.fsf@kernel.org> Date: Mon, 26 Sep 2022 12:27:43 +0300 From: Kalle Valo <kvalo@...nel.org> To: Alvin Šipraga <ALSI@...g-olufsen.dk> Cc: Linus Walleij <linus.walleij@...aro.org>, Konrad Dybcio <konrad.dybcio@...ainline.org>, Hector Martin <marcan@...can.st>, "~postmarketos\/upstreaming\@lists.sr.ht" <~postmarketos/upstreaming@...ts.sr.ht>, "martin.botka\@somainline.org" <martin.botka@...ainline.org>, "angelogioacchino.delregno\@somainline.org" <angelogioacchino.delregno@...ainline.org>, "marijn.suijten\@somainline.org" <marijn.suijten@...ainline.org>, "jamipkettunen\@somainline.org" <jamipkettunen@...ainline.org>, Arend van Spriel <aspriel@...il.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Marek Vasut <marex@...x.de>, "Zhao\, Jiaqing" <jiaqing.zhao@...el.com>, "Russell King \(Oracle\)" <rmk+kernel@...linux.org.uk>, Soon Tak Lee <soontak.lee@...ress.com>, "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>, "brcm80211-dev-list.pdl\@broadcom.com" <brcm80211-dev-list.pdl@...adcom.com>, "SHA-cyfmac-dev-list\@infineon.com" <SHA-cyfmac-dev-list@...ineon.com>, "netdev\@vger.kernel.org" <netdev@...r.kernel.org>, "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] brcmfmac: Add support for BCM43596 PCIe Wi-Fi Alvin Šipraga <ALSI@...g-olufsen.dk> writes: > On Thu, Sep 22, 2022 at 03:02:12PM +0200, Linus Walleij wrote: >> On Thu, Sep 22, 2022 at 12:21 PM Konrad Dybcio >> <konrad.dybcio@...ainline.org> wrote: >> >> > Also worth noting is the 'somc' bit, meaning there are probably *some* SONY >> > customizations, but that's also just a guess. >> >> What I have seen from BRCM customizations on Samsung phones is that >> the per-device customization of firmware seems to involve the set-up of >> some GPIO and power management pins. For example if integrated with >> an SoC that has autonomous system resume, or if some GPIO line has >> to be pulled to enable an external regulator or PA. > > At least with Infineon (formerly Cypress), as a customer you might get a > private firmware and this will be maintained internally by them on a > separate customer branch. Any subsequent bugfixes or feature requests > will usually be applied to that customer branch and a new firmware built > from it. I think their internal "mainline" branch might get merged into > the customer branches from time to time, but this seems to be done on an > ad-hoc basis. This is our experience at least. > > I would also point out that the BCM4359 is equivalent to the > CYW88359/CYW89359 chipset, which we are using in some of our > products. Note that this is a Cypress chipset (identifiable by the > Version: ... (... CY) tag in the version string). But the FW Konrad is > linking appears to be for a Broadcom chipset. > > FYI, here's a publicly available set of firmware files for the '4359: > > https://github.com/NXP/imx-firmware/tree/master/cyw-wifi-bt/1FD_CYW4359 > > Anyway, I would second Hector's suggestion and make this a separate FW. I also recommend having a separate firmware filename. Like Hector said, it's easy to have a symlink in userspace if same binary can be used. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists