linux-kernel - Re: [PATCH net] rhashtable: fix crash due to mm api change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220926102456.GC12777@breakpoint.cc>
Date:   Mon, 26 Sep 2022 12:24:56 +0200
From:   Florian Westphal <fw@...len.de>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Florian Westphal <fw@...len.de>, netdev@...r.kernel.org,
        tgraf@...g.ch, urezki@...il.com, Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, Martin Zaharinov <micron10@...il.com>,
        Michal Hocko <mhocko@...e.com>,
        Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org
Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change

Herbert Xu <herbert@...dor.apana.org.au> wrote:
> Only in the case of kvzalloc.  We expect kzalloc to fail, that's
> why it gets NOWARN.  There is no sane reason for kvzalloc to fail
> so it should warn.

To me a WARN() only has one purpose:
It will get reported to mailing list and a developer can use that
to develop a patch/fix.

In memory allocation failure, there is no bug, so nothing to fix,
so WARN is useless.