linux-kernel - Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be78f14b-3b76-84be-c374-d5b7b7794402@nvidia.com>
Date:   Mon, 26 Sep 2022 13:00:04 +0800
From:   Haotien Hsu <haotienh@...dia.com>
To:     Vinod Koul <vkoul@...nel.org>
CC:     <p.zabel@...gutronix.de>, <jckuo@...dia.com>, <kishon@...com>,
        <thierry.reding@...il.com>, <jonathanh@...dia.com>,
        <linux-phy@...ts.infradead.org>, <linux-tegra@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Wayne Chang <waynec@...dia.com>
Subject: Re: [PATCH] phy: tegra: xusb: Enable usb role switch attribute

On 9/24/22 15:17, Vinod Koul wrote:
> On 21-09-22, 19:25, Haotien Hsu wrote:
>> From: Wayne Chang <waynec@...dia.com>
>>
>> This patch enables the usb-role-switch atrribute
>> to have the user-space check current device role
>> of otg cability ports
> 
> typo cability
> 
> 
> You can use 72 chars for changelog rather than limiting at 50chars :-(
>
Sorry for the typo and bad format.
I will resend this patch.
>>
>> Signed-off-by: Wayne Chang <waynec@...dia.com>
>> Signed-off-by: Haotien Hsu <haotienh@...dia.com>
>> ---
>>   drivers/phy/tegra/xusb.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
>> index aa5237eacd29..220ab7719ade 100644
>> --- a/drivers/phy/tegra/xusb.c
>> +++ b/drivers/phy/tegra/xusb.c
>> @@ -656,6 +656,7 @@ static int tegra_xusb_setup_usb_role_switch(struct tegra_xusb_port *port)
>>   	struct usb_role_switch_desc role_sx_desc = {
>>   		.fwnode = dev_fwnode(&port->dev),
>>   		.set = tegra_xusb_role_sw_set,
>> +		.allow_userspace_control = true,
>>   	};
>>   	int err = 0;
>>   
>> -- 
>> 2.25.1
>