linux-kernel - Re: [PATCH 4/4] tty: serial: do unlock on a common path in altera_jtaguart_console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 16:59:27 +0200
From:   Tobias Klauser <tklauser@...tanz.ch>
To:     Jiri Slaby <jslaby@...e.cz>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] tty: serial: do unlock on a common path in
 altera_jtaguart_console_putc()

On 2022-09-27 at 13:18:19 +0200, Jiri Slaby <jslaby@...e.cz> wrote:
> port->lock is unlocked in each branch in altera_jtaguart_console_putc(),
> so do it before the "if". "status" needs not be under the lock, as the
> register was already read.
> 
> Cc: Tobias Klauser <tklauser@...tanz.ch>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>

Acked-by: Tobias Klauser <tklauser@...tanz.ch>

Thanks