linux-kernel - Re: [PATCH] drm/panel-edp: Fix delays for INX N116BCA-EA2 (HW: C1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 08:12:34 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Sean Hong <sean.hong@...nta.corp-partner.google.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/panel-edp: Fix delays for INX N116BCA-EA2 (HW: C1)

Hi,

On Mon, Sep 26, 2022 at 7:18 PM Sean Hong
<sean.hong@...nta.corp-partner.google.com> wrote:
>
> This panel has the same delay timing as N116BCA-EA1. So, fix the
> delay timing from delay_200_500_p2e80 to delay_200_500_e80_d50.
>
> Signed-off-by: Sean Hong <sean.hong@...nta.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please include "Fixes" tags for patches like this, like:

Fixes: c7bcc1056cff ("drm/panel-edp: Add INX N116BCA-EA2")


> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index 102ab9f5d40a..e25851de7954 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1893,7 +1893,7 @@ static const struct edp_panel_entry edp_panels[] = {
>
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x114c, &innolux_n116bca_ea1.delay, "N116BCA-EA1"),
>         EDP_PANEL_ENTRY('C', 'M', 'N', 0x1152, &delay_200_500_p2e80, "N116BCN-EA1"),
> -       EDP_PANEL_ENTRY('C', 'M', 'N', 0x1154, &delay_200_500_p2e80, "N116BCA-EA2"),
> +       EDP_PANEL_ENTRY('C', 'M', 'N', 0x1154, &delay_200_500_e80_d50, "N116BCA-EA2"),

You just sent two patches that touched adjacent lines in the same
file. That means that they will conflict with each other and I've got
to resolve the conflict. :( It's not that hard in this case, but it
would have been better if instead you did:

1. Put both changes in one patch. I think that would have been fine in
this case.

-or-

2. Send both patches in a 2-part series.

In any case, I won't ask you to spin just for this since it's trivial
to resolve, it's just more work for me. Please don't do this in the
future.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

Pushed to drm-misc-next:

43113fd4c5f5 drm/panel-edp: Fix delays for INX N116BCA-EA2 (HW: C1)