linux-kernel - Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzMcL/wktFyKO06K@google.com>
Date:   Tue, 27 Sep 2022 08:52:15 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jerome Neanne <jneanne@...libre.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org,
        nm@...com, kristo@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        catalin.marinas@....com, will@...nel.org, lee@...nel.org,
        tony@...mide.com, vigneshr@...com, bjorn.andersson@...aro.org,
        shawnguo@...nel.org, geert+renesas@...der.be,
        dmitry.baryshkov@...aro.org, marcel.ziswiler@...adex.com,
        vkoul@...nel.org, biju.das.jz@...renesas.com, arnd@...db.de,
        jeff@...undy.com, afd@...com, khilman@...libre.com,
        narmstrong@...libre.com, msp@...libre.com, j-keerthy@...com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v5 5/6] Input: Add tps65219 interrupt driven powerbutton

Hi Jerome,

On Tue, Sep 27, 2022 at 10:35:19AM +0200, Jerome Neanne wrote:
> +static int tps65219_pb_probe(struct platform_device *pdev)
> +{
> +	struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent);
> +	struct device *dev = &pdev->dev;
> +	struct tps65219_pwrbutton *pwr;
> +	struct input_dev *idev;
> +	int error;
> +	int push_irq;
> +	int release_irq;
> +
> +	pwr = devm_kzalloc(dev, sizeof(*pwr), GFP_KERNEL);
> +	if (!pwr)
> +		return -ENOMEM;
> +
> +	idev = devm_input_allocate_device(dev);
> +	if (!idev)
> +		return -ENOMEM;
> +
> +	idev->name = pdev->name;
> +	snprintf(pwr->phys, sizeof(pwr->phys), "%s/input0",
> +		 pdev->name);
> +	idev->phys = pwr->phys;
> +	idev->dev.parent = dev;

As I mentioned in my previous email, this assignment is not needed given
that devm_input_allocate_device() is used. Otherwise:

Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Please feel free to merge through MFD tree.

Thanks.

-- 
Dmitry