linux-kernel - arch/riscv/kernel/probes/rethook.c:10:22: warning: no previous prototype for 'arch_rethook_trampoline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 00:35:06 +0800
From:   kernel test robot <lkp@...el.com>
To:     Binglei Wang <l3b2w1@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        0day robot <lkp@...el.com>
Subject: arch/riscv/kernel/probes/rethook.c:10:22: warning: no previous
 prototype for 'arch_rethook_trampoline_callback'

tree:   https://github.com/intel-lab-lkp/linux/commits/UPDATE-20220922-192113/Binglei-Wang/rethook-add-riscv-rethook-implementation/20220922-120748
head:   6fbbb233363dcd9649fc826d9538935346b02923
commit: 6fbbb233363dcd9649fc826d9538935346b02923 rethook: add riscv rethook implementation.
date:   5 days ago
config: riscv-randconfig-c003-20220925
compiler: riscv32-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/6fbbb233363dcd9649fc826d9538935346b02923
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review UPDATE-20220922-192113/Binglei-Wang/rethook-add-riscv-rethook-implementation/20220922-120748
        git checkout 6fbbb233363dcd9649fc826d9538935346b02923
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash arch/riscv/kernel/probes/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

Note: functions only called from assembly code should be annotated with the asmlinkage attribute
All warnings (new ones prefixed by >>):

>> arch/riscv/kernel/probes/rethook.c:10:22: warning: no previous prototype for 'arch_rethook_trampoline_callback' [-Wmissing-prototypes]
      10 | unsigned long __used arch_rethook_trampoline_callback(struct pt_regs *regs)
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   arch/riscv/kernel/probes/rethook.c: In function 'arch_rethook_prepare':
>> arch/riscv/kernel/probes/rethook.c:23:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
      23 |         regs->ra = (u64)arch_rethook_trampoline;
         |                    ^


vim +/arch_rethook_trampoline_callback +10 arch/riscv/kernel/probes/rethook.c

     8	
     9	/* This is called from arch_rethook_trampoline() */
  > 10	unsigned long __used arch_rethook_trampoline_callback(struct pt_regs *regs)
    11	{
    12		return rethook_trampoline_handler(regs, regs->s0);
    13	}
    14	NOKPROBE_SYMBOL(arch_rethook_trampoline_callback);
    15	
    16	
    17	void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount)
    18	{
    19		rhn->ret_addr = regs->ra;
    20		rhn->frame = regs->s0;
    21	
    22		/* replace return addr with trampoline */
  > 23		regs->ra = (u64)arch_rethook_trampoline;

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (139524 bytes)