linux-kernel - Re: [PATCH] usb: gadget: uvc: fix sg handling in error case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzMoCMIh85XxWcdh@kroah.com>
Date:   Tue, 27 Sep 2022 18:42:48 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Dan Vacura <w36195@...orola.com>
Cc:     linux-usb@...r.kernel.org,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        stable@...r.kernel.org,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Felipe Balbi <balbi@...nel.org>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: uvc: fix sg handling in error case

On Tue, Sep 27, 2022 at 10:47:55AM -0500, Dan Vacura wrote:
> Hi Greg,
> 
> On Tue, Sep 27, 2022 at 10:33:34AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Sep 26, 2022 at 02:53:07PM -0500, Dan Vacura wrote:
> > > If there is a transmission error the buffer will be returned too early,
> > > causing a memory fault as subsequent requests for that buffer are still
> > > queued up to be sent. Refactor the error handling to wait for the final
> > > request to come in before reporting back the buffer to userspace for all
> > > transfer types (bulk/isoc/isoc_sg) to ensure userspace knows if the
> > > frame was successfully sent.
> > > 
> > > Fixes: e81e7f9a0eb9 ("usb: gadget: uvc: add scatter gather support")
> > > Cc: <stable@...r.kernel.org> # 859c675d84d4: usb: gadget: uvc: consistently use define for headerlen
> > > Cc: <stable@...r.kernel.org> # f262ce66d40c: usb: gadget: uvc: use on returned header len in video_encode_isoc_sg
> > > Cc: <stable@...r.kernel.org> # 61aa709ca58a: usb: gadget: uvc: rework uvcg_queue_next_buffer to uvcg_complete_buffer
> > > Cc: <stable@...r.kernel.org> # 9b969f93bcef: usb: gadget: uvc: giveback vb2 buffer on req complete
> > > Cc: <stable@...r.kernel.org> # aef11279888c: usb: gadget: uvc: improve sg exit condition
> > 
> > I don't understand, why we backport all of these commits to 5.15.y if
> > the original problem isn't in 5.15.y?
> > 
> > Or is it?
> > 
> > I'm confused,
> 
> It seems we have a regression in 5.15 with some recent, still in
> development, features for the uvc gadget driver. Compared to the last
> kernel I worked with, 5.10, I'm seeing stability and functional issues
> in 5.15, explained in my summary here:
> https://lore.kernel.org/all/20220926195307.110121-1-w36195@motorola.com/
> 
> I think we have few approaches.
> 1) Work through these issues and get the fixes into mainline and stable
> versions, this patch starts that effort, but there's still more work to
> be done.
> 2) Revert the changes that are causing regressions in 5.15 (two changes
> from what I can see).
> 3) Add a configfs ability to allow sg isoc transfers and couple the
> quarter interrupt logic to only sg xfers.
> 
> Approach 2 is my preference, as there are issues still present that need
> to be figured out. However, I don't know how we can revert to just a
> stable line. I'm basically looking for feedback and input for the next
> steps, and if it's just me with these issues on 5.15.

Worry about the latest kernel release first.  Once we get things fixed
there, we can backport any needed changes to older stable/LTS kernels as
needed.

We can't go back in time and do new development on older kernels.

For Android devices, you can always use the `android-mainline` AOSP
kernel branch as it is up to date with Linus's tree at all times and is
known to successfully boot and run at least one real device.


> > >  #define UVC_QUEUE_DISCONNECTED		(1 << 0)
> > > -#define UVC_QUEUE_DROP_INCOMPLETE	(1 << 1)
> > > +#define UVC_QUEUE_MISSED_XFER 		(1 << 1)
> > 
> > Why change the name of the error?
> 
> I thought MISSED_XFER was a more explicit name to what is going on,
> instead of an action. I can change it back.

That's fine, but you didn't document why you were doing this.

Perhaps this needs to be a patch series, remember, each patch only
should do 1 thing.

> > > +	case -EXDEV:
> > > +		uvcg_info(&video->uvc->func, "VS request missed xfer.\n");
> > 
> > Why are you spamming the kernel logs at the info level for a USB
> > transmission problem?   That could get very noisy, please change this to
> > be at the debug level.
> 
> Previously this would printout as a dev_warn in a725d0f6dfc5 ("usb:
> gadget: uvc: call uvc uvcg_warn on completed status instead of
> uvcg_info"), which I think might be too noisy. Info is helpful to
> see what's going on if there is video corruption, but I can change to a
> dbg as well.

info is never a valid level for an error.  dbg is best if a user can not
actually do something about the error.

thanks,

greg k-h