linux-kernel - Re: [PATCH -next] android: binder: Remove comments about tsk fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzM1QkafOVNuNLkp@google.com>
Date:   Tue, 27 Sep 2022 17:39:14 +0000
From:   Carlos Llamas <cmllamas@...gle.com>
To:     Zhang Qiao <zhangqiao22@...wei.com>
Cc:     gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
        surenb@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] android: binder: Remove comments about tsk fields

On Wed, Sep 28, 2022 at 08:46:10AM +0800, Zhang Qiao wrote:
> Commit a0c2baaf81bd ("android: binder: Don't get mm
> from task") remove the binder_alloc struct's tsk, but
> didn't remove the header commment about '@...'.
> So this patch remove it.
> 
> Signed-off-by: Zhang Qiao <zhangqiao22@...wei.com>
> ---
>  drivers/android/binder_alloc.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/android/binder_alloc.h b/drivers/android/binder_alloc.h
> index 1e4fd37af5e0..fe0738fb9c8c 100644
> --- a/drivers/android/binder_alloc.h
> +++ b/drivers/android/binder_alloc.h
> @@ -76,8 +76,6 @@ struct binder_lru_page {
>   * struct binder_alloc - per-binder proc state for binder allocator
>   * @vma:                vm_area_struct passed to mmap_handler
>   *                      (invarient after mmap)
> - * @tsk:                tid for task that called init for this proc
> - *                      (invariant after init)
>   * @vma_vm_mm:          copy of vma->vm_mm (invarient after mmap)
>   * @buffer:             base of per-proc address space mapped via mmap
>   * @buffers:            list of all buffers for this proc
> -- 
> 2.17.1
> 

Thanks but this has already been addressed here:
https://git.kernel.org/next/linux-next/c/7b0dbd940765
--
Carlos Llamas