[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <caf2949a-e98d-e0a2-dc8a-af632d9b610a@linux.intel.com>
Date: Tue, 27 Sep 2022 12:34:52 -0700
From: Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@...ux.intel.com>
To: Zhuo Chen <chenzhuo.1@...edance.com>, bhelgaas@...gle.com,
ruscur@...sell.cc, oohall@...il.com, fancer.lancer@...il.com,
jdmason@...zu.us, dave.jiang@...el.com, allenbh@...il.com,
james.smart@...adcom.com, dick.kennedy@...adcom.com,
jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc: linuxppc-dev@...ts.ozlabs.org, linux-pci@...r.kernel.org,
linux-kernel@...r.kernel.org, ntb@...ts.linux.dev,
linux-scsi@...r.kernel.org
Subject: Re: [PATCH v2 2/9] PCI/DPC: Use
pci_aer_clear_uncorrect_error_status() to clear uncorrectable error status
Hi,
On 9/27/22 8:35 AM, Zhuo Chen wrote:
> Use pci_aer_clear_nonfatal_status() in dpc_process_error(), which has
> no functional changes.
Just say pci_aer_clear_uncorrect_error_status() clears both fatal and
non-fatal errors. So use it in place of pci_aer_clear_nonfatal_status()
and pci_aer_clear_fatal_status().
>
> Signed-off-by: Zhuo Chen <chenzhuo.1@...edance.com>
> ---
> drivers/pci/pcie/dpc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c
> index 3e9afee02e8d..7942073fbb34 100644
> --- a/drivers/pci/pcie/dpc.c
> +++ b/drivers/pci/pcie/dpc.c
> @@ -288,8 +288,7 @@ void dpc_process_error(struct pci_dev *pdev)
> dpc_get_aer_uncorrect_severity(pdev, &info) &&
> aer_get_device_error_info(pdev, &info)) {
> aer_print_error(pdev, &info);
> - pci_aer_clear_nonfatal_status(pdev);
> - pci_aer_clear_fatal_status(pdev);
> + pci_aer_clear_uncorrect_error_status(pdev);
> }
> }
>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
Powered by blists - more mailing lists