linux-kernel - Re: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzNUrsFbG0vfP1Rx@shikoro>
Date:   Tue, 27 Sep 2022 21:53:18 +0200
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Asmaa Mnebhi <asmaa@...dia.com>
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        Khalil Blaiech <kblaiech@...dia.com>
Subject: Re: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC


> +		ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> +					      MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

> +		priv->timer->io = priv->smbus->io;
> +		priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> +		priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)