linux-kernel - RE: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH2PR12MB38955850E07D41FC6947443DD7559@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Tue, 27 Sep 2022 19:56:58 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Khalil Blaiech <kblaiech@...dia.com>
Subject: RE: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC



> +		ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> +					      MLXBF_I2C_SMBUS_RES);

Did you maybe forget to check 'ret' here?

Yes will do!
> +		priv->timer->io = priv->smbus->io;
> +		priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> +		priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;