linux-kernel - RE: [PATCH v7 1/2] i2c: mlxbf: support BlueField-3 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CH2PR12MB3895CE98DCE26556680A6FDAD7559@CH2PR12MB3895.namprd12.prod.outlook.com>
Date:   Tue, 27 Sep 2022 21:00:42 +0000
From:   Asmaa Mnebhi <asmaa@...dia.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
CC:     "linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Khalil Blaiech <kblaiech@...dia.com>
Subject: RE: [PATCH v7 1/2] i2c: mlxbf: support BlueField-3 SoC

Thank you Wolfram!

-----Original Message-----
From: Wolfram Sang <wsa+renesas@...g-engineering.com> 
Sent: Tuesday, September 27, 2022 4:47 PM
To: Asmaa Mnebhi <asmaa@...dia.com>
Cc: linux-i2c@...r.kernel.org; linux-kernel@...r.kernel.org; Khalil Blaiech <kblaiech@...dia.com>
Subject: Re: [PATCH v7 1/2] i2c: mlxbf: support BlueField-3 SoC

On Tue, Sep 27, 2022 at 04:39:23PM -0400, Asmaa Mnebhi wrote:
> BlueField-3 SoC has the same I2C IP logic as previous
> BlueField-1 and 2 SoCs but it has different registers' addresses.
> This is an effort to keep this driver generic accross all BlueField 
> generations.
> This patch breaks down the "smbus" resource into 3 separate resources 
> to enable us to use common registers' offsets for all BlueField SoCs:
> struct mlxbf_i2c_resource *timer;
> struct mlxbf_i2c_resource *mst;
> struct mlxbf_i2c_resource *slv;
> 
> Of course, all offsets had to be adjusted accordingly, and we took 
> this chance to reorganize the macros depending on the register block 
> they target.
> 
> There are only 2 registers' offsets that do not fit within this schema 
> so their offsets are passed as SoC-specific parameters:
> smbus_master_rs_bytes_off
> smbus_master_fsm_off
> 
> Reviewed-by: Khalil Blaiech <kblaiech@...dia.com>
> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>

Applied to for-next, thanks!