linux-kernel - RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR10MB46238985ADC07034B781A338FD559@SJ0PR10MB4623.namprd10.prod.outlook.com>
Date:   Tue, 27 Sep 2022 21:41:04 +0000
From:   Thomas Tai <thomas.tai@...cle.com>
To:     "Luck, Tony" <tony.luck@...el.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "jarkko@...nel.org" <jarkko@...nel.org>,
        "reinette.chatre@...el.co" <reinette.chatre@...el.co>,
        "naoya.horiguchi@....com" <naoya.horiguchi@....com>,
        "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory

> -----Original Message-----
> From: Luck, Tony <tony.luck@...el.com>
> Sent: September 27, 2022 4:35 PM
> To: Thomas Tai <thomas.tai@...cle.com>; dave.hansen@...ux.intel.com;
> jarkko@...nel.org; reinette.chatre@...el.co; naoya.horiguchi@....com;
> linmiaohe@...wei.com; akpm@...ux-foundation.org; linux-mm@...ck.org;
> linux-kernel@...r.kernel.org; Thomas Tai <thomas.tai@...cle.com>
> Subject: RE: [PATCH] x86/sgx: Add code to inject hwpoison into SGX memory
> 
> > Inspired by commit c6acb1e7bf46 (x86/sgx: Add hook to error injection
> > address validation), add a similar code in hwpoison_inject function to
> > check if the address is located in SGX Memory. The error will then be
> > handled by the arch_memory_failure function in the SGX driver.
> 
> Looks good to me.
> 
> [I wish that Linux hadn't called this "hwpoison_inject()" because there's nothing
> hardware related about this injection. But you are just an innocent consumer of
> that poor naming choice]
> 
> Reviewed-by: Tony Luck <tony.luck@...el.com>

Thanks, Tony, for your review.

Cheers,
Thomas

> 
> -Tony