[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACGkMEtnsBEu6nm0oFCJyQwwf5PzdMRAsbzZZPZZ1TS9vRg1RQ@mail.gmail.com>
Date: Tue, 27 Sep 2022 12:01:30 +0800
From: Jason Wang <jasowang@...hat.com>
To: Deming Wang <wangdeming@...pur.com>
Cc: mst <mst@...hat.com>,
virtualization <virtualization@...ts.linux-foundation.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] virtio_ring: Drop unnecessary initialization of detach_buf_packed
On Mon, Sep 26, 2022 at 7:15 PM Deming Wang <wangdeming@...pur.com> wrote:
>
> The variable is initialized but it is only used after its assignment.
>
> Signed-off-by: Deming Wang <wangdeming@...pur.com>
Acked-by: Jason Wang <jasowang@...hat.com>
> ---
> drivers/virtio/virtio_ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> index 8974c34b40fd..abac0a3de440 100644
> --- a/drivers/virtio/virtio_ring.c
> +++ b/drivers/virtio/virtio_ring.c
> @@ -1544,7 +1544,7 @@ static bool virtqueue_kick_prepare_packed(struct virtqueue *_vq)
> static void detach_buf_packed(struct vring_virtqueue *vq,
> unsigned int id, void **ctx)
> {
> - struct vring_desc_state_packed *state = NULL;
> + struct vring_desc_state_packed *state;
> struct vring_packed_desc *desc;
> unsigned int i, curr;
>
> --
> 2.27.0
>
Powered by blists - more mailing lists