linux-kernel - Re: [PATCH] serial: Convert serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0432cfc3-88e2-5d36-539a-757017b3089d@kernel.org>
Date:   Tue, 27 Sep 2022 07:16:25 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH] serial: Convert serial_rs485 to kernel doc

On 26. 09. 22, 14:37, Ilpo Järvinen wrote:
> Convert struct serial_rs485 comments to kernel doc format.

It'd be nice if you referenced the struct from Documentation/, so that 
it is: 1) checked, and 2) rendered somewhere.

> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> 
> ---
>   include/uapi/linux/serial.h | 61 +++++++++++++++++++++++++++++----------------
>   1 file changed, 40 insertions(+), 21 deletions(-)
> 
> diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
> index cea06924b295..67d4bc663521 100644
> --- a/include/uapi/linux/serial.h
> +++ b/include/uapi/linux/serial.h
> @@ -107,37 +107,56 @@ struct serial_icounter_struct {
>   	int reserved[9];
>   };
>   
> -/*
> +/**
> + * struct serial_rs485 - serial interface for controlling RS485 settings.
...
thanks,
-- 
js
suse labs