linux-kernel - Re: [PATCH net] rhashtable: fix crash due to mm api change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzKgcvHhjU7B5EOj@gondor.apana.org.au>
Date:   Tue, 27 Sep 2022 15:04:18 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org, tgraf@...g.ch, urezki@...il.com,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
        akpm@...ux-foundation.org, Martin Zaharinov <micron10@...il.com>,
        Michal Hocko <mhocko@...e.com>,
        Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org
Subject: Re: [PATCH net] rhashtable: fix crash due to mm api change

On Mon, Sep 26, 2022 at 12:24:56PM +0200, Florian Westphal wrote:
.
> In memory allocation failure, there is no bug, so nothing to fix,
> so WARN is useless.

It depends on why it failed.  If it failed because we're asking
for something that simply can't be fulfilled then sure.  But if
we're asking for something sane and kvzalloc still failed it then
we should know about it.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt