linux-kernel - [mkp-scsi:for-next 59/141] checkpatch: WARNING: debugfs_remove(NULL) is safe and this check is probably not required

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <af34adb9-7772-f96a-ca36-73e898a3419e@intel.com>
Date:   Tue, 27 Sep 2022 09:26:19 +0800
From:   kernel test robot <yujie.liu@...el.com>
To:     Arun Easi <aeasi@...vell.com>
CC:     <kbuild-all@...ts.01.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Himanshu Madhani <himanshu.madhani@...cle.com>,
        Nilesh Javali <njavali@...vell.com>
Subject: [mkp-scsi:for-next 59/141] checkpatch: WARNING: debugfs_remove(NULL)
 is safe and this check is probably not required

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head:   57569c37f0add1b6489e1a1563c71519daf732cf
commit: 389f179b868e43121c6cfccfbf5e495842a766fd [59/141] scsi: qla2xxx: Add debugfs create/delete helpers
reproduce:
         scripts/checkpatch.pl 0001-scsi-qla2xxx-Add-debugfs-create-delete-helpers.patch

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <yujie.liu@...el.com>

# many are suggestions rather than must-fix

WARNING: macros should not use a trailing semicolon
#71: drivers/scsi/qla2xxx/qla_dfs.c:521:
+#define QLA_DFS_SETUP_RD(_name, _ctx_struct)				\
+static int								\
+qla_dfs_##_name##_open(struct inode *inode, struct file *file)		\
+{									\
+	_ctx_struct *__ctx = inode->i_private;				\
+									\
+	return single_open(file, qla_dfs_##_name##_show, __ctx);	\
+}									\
+									\
+static const struct file_operations qla_dfs_##_name##_ops = {		\
+	.open           = qla_dfs_##_name##_open,			\
+	.read           = seq_read,					\
+	.llseek         = seq_lseek,					\
+	.release        = single_release,				\
+};

WARNING: macros should not use a trailing semicolon
#87: drivers/scsi/qla2xxx/qla_dfs.c:537:
+#define QLA_DFS_SETUP_RW(_name, _ctx_struct)				\
+static int								\
+qla_dfs_##_name##_open(struct inode *inode, struct file *file)		\
+{									\
+	_ctx_struct *__ctx = inode->i_private;				\
+									\
+	return single_open(file, qla_dfs_##_name##_show, __ctx);	\
+}									\
+									\
+static const struct file_operations qla_dfs_##_name##_ops = {		\
+	.open           = qla_dfs_##_name##_open,			\
+	.read           = seq_read,					\
+	.llseek         = seq_lseek,					\
+	.release        = single_release,				\
+	.write		= qla_dfs_##_name##_write,			\
+};

WARNING: debugfs_remove(NULL) is safe and this check is probably not required
#115: drivers/scsi/qla2xxx/qla_dfs.c:565:
+		if (qla_dfs_##_name) {					\
+			debugfs_remove(qla_dfs_##_name);		\

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp