linux-kernel - Re: [PATCH] Revert "net: set proper memcg for net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <54078150-3c22-3563-7731-5c7fda85987d@kernel.org>
Date:   Tue, 27 Sep 2022 12:02:23 +0200
From:   "Vlastimil Babka (SUSE)" <vbabka@...nel.org>
To:     Shakeel Butt <shakeelb@...gle.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Hocko <mhocko@...nel.org>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Muchun Song <songmuchun@...edance.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Michal Koutný <mkoutny@...e.com>,
        cgroups@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Anatoly Pugachev <matorola@...il.com>,
        Vasily Averin <vvs@...nvz.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        sparclinux@...r.kernel.org, regressions@...ts.linux.dev
Subject: Re: [PATCH] Revert "net: set proper memcg for net_init hooks
 allocations"

On 9/26/22 21:59, Shakeel Butt wrote:
> This reverts commit 1d0403d20f6c281cb3d14c5f1db5317caeec48e9.
> 
> Anatoly Pugachev reported that the commit 1d0403d20f6c ("net: set proper
> memcg for net_init hooks allocations") is somehow causing the sparc64
> VMs failed to boot and the VMs boot fine with that patch reverted. So,
> revert the patch for now and later we can debug the issue.
> 

Link: https://lore.kernel.org/all/20220918092849.GA10314@u164.east.ru/

(mainly for regzbot reading this thread but should be valid usage for
the report anyway)

Fixes: 1d0403d20f6c ("net: set proper memcg for net_init hooks allocations")

> Reported-by: Anatoly Pugachev <matorola@...il.com>
> Signed-off-by: Shakeel Butt <shakeelb@...gle.com>
> Cc: Vasily Averin <vvs@...nvz.org>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Michal Koutný <mkoutny@...e.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: cgroups@...r.kernel.org
> Cc: sparclinux@...r.kernel.org
> Cc: linux-mm@...ck.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  include/linux/memcontrol.h | 45 --------------------------------------
>  net/core/net_namespace.c   |  7 ------
>  2 files changed, 52 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index ef479e554253..e1644a24009c 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1787,42 +1787,6 @@ static inline void count_objcg_event(struct obj_cgroup *objcg,
>  	rcu_read_unlock();
>  }
>  
> -/**
> - * get_mem_cgroup_from_obj - get a memcg associated with passed kernel object.
> - * @p: pointer to object from which memcg should be extracted. It can be NULL.
> - *
> - * Retrieves the memory group into which the memory of the pointed kernel
> - * object is accounted. If memcg is found, its reference is taken.
> - * If a passed kernel object is uncharged, or if proper memcg cannot be found,
> - * as well as if mem_cgroup is disabled, NULL is returned.
> - *
> - * Return: valid memcg pointer with taken reference or NULL.
> - */
> -static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p)
> -{
> -	struct mem_cgroup *memcg;
> -
> -	rcu_read_lock();
> -	do {
> -		memcg = mem_cgroup_from_obj(p);
> -	} while (memcg && !css_tryget(&memcg->css));
> -	rcu_read_unlock();
> -	return memcg;
> -}
> -
> -/**
> - * mem_cgroup_or_root - always returns a pointer to a valid memory cgroup.
> - * @memcg: pointer to a valid memory cgroup or NULL.
> - *
> - * If passed argument is not NULL, returns it without any additional checks
> - * and changes. Otherwise, root_mem_cgroup is returned.
> - *
> - * NOTE: root_mem_cgroup can be NULL during early boot.
> - */
> -static inline struct mem_cgroup *mem_cgroup_or_root(struct mem_cgroup *memcg)
> -{
> -	return memcg ? memcg : root_mem_cgroup;
> -}
>  #else
>  static inline bool mem_cgroup_kmem_disabled(void)
>  {
> @@ -1879,15 +1843,6 @@ static inline void count_objcg_event(struct obj_cgroup *objcg,
>  {
>  }
>  
> -static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p)
> -{
> -	return NULL;
> -}
> -
> -static inline struct mem_cgroup *mem_cgroup_or_root(struct mem_cgroup *memcg)
> -{
> -	return NULL;
> -}
>  #endif /* CONFIG_MEMCG_KMEM */
>  
>  #if defined(CONFIG_MEMCG_KMEM) && defined(CONFIG_ZSWAP)
> diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
> index 6b9f19122ec1..0ec2f5906a27 100644
> --- a/net/core/net_namespace.c
> +++ b/net/core/net_namespace.c
> @@ -18,7 +18,6 @@
>  #include <linux/user_namespace.h>
>  #include <linux/net_namespace.h>
>  #include <linux/sched/task.h>
> -#include <linux/sched/mm.h>
>  #include <linux/uidgid.h>
>  #include <linux/cookie.h>
>  
> @@ -1144,13 +1143,7 @@ static int __register_pernet_operations(struct list_head *list,
>  		 * setup_net() and cleanup_net() are not possible.
>  		 */
>  		for_each_net(net) {
> -			struct mem_cgroup *old, *memcg;
> -
> -			memcg = mem_cgroup_or_root(get_mem_cgroup_from_obj(net));
> -			old = set_active_memcg(memcg);
>  			error = ops_init(ops, net);
> -			set_active_memcg(old);
> -			mem_cgroup_put(memcg);
>  			if (error)
>  				goto out_undo;
>  			list_add_tail(&net->exit_list, &net_exit_list);