linux-kernel - Re: [PATCH 2/4] watchdog: twl4030

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b308e474-505d-0e53-ff13-fc53f1afa46b@roeck-us.net>
Date:   Tue, 27 Sep 2022 03:55:32 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lee Jones <lee@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Tony Lindgren <tony@...mide.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-iio@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include

On 9/26/22 22:22, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/twl4030_wdt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..e715ac1369a0 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
>   #include <linux/types.h>
>   #include <linux/slab.h>
>   #include <linux/kernel.h>
> +#include <linux/of.h>
>   #include <linux/watchdog.h>
>   #include <linux/platform_device.h>
>   #include <linux/mfd/twl.h>