linux-kernel - Re: [PATCH v5 2/5] Revert "frontswap: simplify frontswap_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <986efc9f-0deb-f705-dff1-f4d5992c2b8d@huawei.com>
Date:   Tue, 27 Sep 2022 19:12:58 +0800
From:   Liu Shixin <liushixin2@...wei.com>
To:     Christoph Hellwig <hch@....de>
CC:     Seth Jennings <sjenning@...hat.com>,
        Dan Streetman <ddstreet@...e.org>,
        Vitaly Wool <vitaly.wool@...sulko.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Nathan Chancellor <nathan@...nel.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>
Subject: Re: [PATCH v5 2/5] Revert "frontswap: simplify
 frontswap_register_ops"



On 2022/9/27 15:27, Christoph Hellwig wrote:
> On Wed, Sep 21, 2022 at 09:42:41AM +0800, Liu Shixin wrote:
>> This revert makes code complicated, but I think it's necessary. When
>> enable zswap, I expect it to work for all swap devices as much as
>> possible.
> But why would expect something to work on a device that has been
> swapped on before?  That's not usually how things work.
>
> .
If not do this, while some user enable swap device first and then enable zswap,
zswap will not take effect. The user need to re-enable the swap device which is
inconvenient.
>