linux-kernel - Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 13:25:47 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     xen-devel@...ts.xenproject.org, x86@...nel.org,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace
 mtrr_aps_delayed_init

On 27.09.22 13:19, Borislav Petkov wrote:
> On Tue, Sep 27, 2022 at 12:14:42PM +0200, Juergen Gross wrote:
>> Yes: cpu hotplug.
> 
> You might need to elaborate here.
> 
> Because I see mtrr_ap_init() on the AP hotplug path:
> 
> native_cpu_up->
> do_boot_cpu->
> start_secondary->
> smp_callin->
> smp_store_cpu_info->
> identify_secondary_cpu->
> mtrr_ap_init
> 
> Which then means that we could check in mtrr_ap_init() if we're on the
> hotplug path and still get rid of that stupid bool...
> 
> Close?
> 

You mean by replacing it with "(system_state != SYSTEM_RUNNING)" ?


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)