linux-kernel - Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2022 07:37:07 -0400
From:   Marc Zyngier <maz@...nel.org>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Huacai Chen" <chenhuacai@...ngson.cn>,
        "Thomas Gleixner" <tglx@...utronix.de>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, "Xuefeng Li" <lixuefeng@...ngson.cn>,
        "Huacai Chen" <chenhuacai@...il.com>,
        "Jiaxun Yang" <jiaxun.yang@...goat.com>
Subject: Re: [PATCH] irqchip: Make irqchip_init() usable on pure ACPI systems

On Tue, 27 Sep 2022 03:51:04 -0400,
"Arnd Bergmann" <arnd@...db.de> wrote:
> 
> On Tue, Sep 27, 2022, at 6:55 AM, Huacai Chen wrote:
> 
> > @@ -28,7 +28,9 @@ extern struct of_device_id __irqchip_of_table[];
> > 
> >  void __init irqchip_init(void)
> >  {
> > +#ifdef CONFIG_OF_IRQ
> >  	of_irq_init(__irqchip_of_table);
> > +#endif
> >  	acpi_probe_device_table(irqchip);
> >  }
> 
> I think that #ifdef should be in the include/linux/of_irq.h
> header, with an empty inline function in the #else path.

Agreed. Please keep the C code free of #ifdefs if at all possible.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.