linux-kernel - Re: [PATCH 2/4] watchdog: twl4030

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzLrTx3uvrSMDgrc@smile.fi.intel.com>
Date:   Tue, 27 Sep 2022 15:23:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Tony Lindgren <tony@...mide.com>, linux-iio@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/4] watchdog: twl4030_wdt: add missing of.h include

On Mon, Sep 26, 2022 at 10:22:14PM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> of.h header.

This is incorrect. For of_device_id the mod_devicetable.h should be used.

> We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.

-- 
With Best Regards,
Andy Shevchenko