linux-kernel - Re: [PATCH 3/4] mfd: twl4030-irq: add missing device.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzLrqADfXO3x38h7@smile.fi.intel.com>
Date:   Tue, 27 Sep 2022 15:25:12 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Guenter Roeck <linux@...ck-us.net>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Tony Lindgren <tony@...mide.com>, linux-iio@...r.kernel.org,
        linux-watchdog@...r.kernel.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mfd: twl4030-irq: add missing device.h include

On Mon, Sep 26, 2022 at 10:22:15PM -0700, Dmitry Torokhov wrote:
> The driver is using "struct device" and therefore needs to include
> device.h header. We used to get this definition indirectly via inclusion
> of matrix_keypad.h from twl.h, but we are cleaning up matrix_keypad.h
> from unnecessary includes.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>  drivers/mfd/twl4030-irq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c
> index 4f576f0160a9..87496c1cb8bc 100644
> --- a/drivers/mfd/twl4030-irq.c
> +++ b/drivers/mfd/twl4030-irq.c
> @@ -14,6 +14,7 @@
>   * by syed khasim <x0khasim@...com>
>   */
>  
> +#include <linux/device.h>
>  #include <linux/export.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
> -- 
> 2.38.0.rc1.362.ged0d419d3c-goog
> 

-- 
With Best Regards,
Andy Shevchenko