lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Sep 2022 14:48:19 +0200 From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com> To: Kees Cook <keescook@...omium.org> Cc: Konstantin Shelekhin <k.shelekhin@...ro.com>, ojeda@...nel.org, boqun.feng@...il.com, gregkh@...uxfoundation.org, jarkko@...nel.org, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, patches@...ts.linux.dev, rust-for-linux@...r.kernel.org, torvalds@...ux-foundation.org Subject: Re: [PATCH v9 01/27] kallsyms: use `sizeof` instead of hardcoded size On Thu, Aug 18, 2022 at 6:03 PM Kees Cook <keescook@...omium.org> wrote: > > Oh, that's an excellent point; I forgot it'll actually compile-time > error if the var is a pointer. +1 In this case it doesn't, because `scripts/kallsyms.c` defines its own `ARRAY_SIZE` that doesn't have the `__must_be_array`. I have changed it for v10 anyway, since that way we may benefit in the future if the `ARRAY_SIZE` here gains the check. Cheers, Miguel
Powered by blists - more mailing lists