linux-kernel - Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03ac1fb3-ea5d-d5b8-1d7e-92c13fba339d@linux.ibm.com>
Date:   Tue, 27 Sep 2022 15:31:47 +0200
From:   Alexandra Winter <wintera@...ux.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Jules Irenge <jbi.octave@...il.com>
Cc:     borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, agordeev@...ux.ibm.com
Subject: Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf()



On 27.09.22 02:33, Jakub Kicinski wrote:
> On Mon, 26 Sep 2022 19:42:38 +0100 Jules Irenge wrote:
>> Coccinnelle reports a warning
>> Warning: Use scnprintf or sprintf
>> Adding to that, there has been a slow migration from snprintf to scnprintf.
>> This LWN article explains the rationale for this change
>> https: //lwn.net/Articles/69419/
>> Ie. snprintf() returns what *would* be the resulting length,
>> while scnprintf() returns the actual length.
>>
>> Signed-off-by: Jules Irenge <jbi.octave@...il.com>
> 
> Looks legit but please repost this separately.
> We only see patch 3 of the series.
When you repost, you can add
Reviewed-by: Alexandra Winter <wintera@...ux.ibm.com>

Thank you
Alexandra