linux-kernel - Re: [PATCH v8 6/7] remoteproc: qcom: Add efuse evb selection control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfe05eec-f3bc-36bc-405f-b3355945ec51@quicinc.com>
Date:   Tue, 27 Sep 2022 18:50:43 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <linux-remoteproc@...r.kernel.org>, <agross@...nel.org>,
        <andersson@...nel.org>, <lgirdwood@...il.com>,
        <broonie@...nel.org>, <robh+dt@...nel.org>,
        <quic_plai@...cinc.com>, <bgoswami@...cinc.com>, <perex@...ex.cz>,
        <tiwai@...e.com>, <srinivas.kandagatla@...aro.org>,
        <quic_rohkumar@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <swboyd@...omium.org>,
        <judyhsiao@...omium.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v8 6/7] remoteproc: qcom: Add efuse evb selection control


On 9/23/2022 10:55 PM, Krzysztof Kozlowski wrote:
Thanks for Your time Krzyszto!!!
> On 23/09/2022 15:05, Srinivasa Rao Mandadapu wrote:
>> Add efuse evb selection control and enable it for starting ADSP.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
>> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
>> Reviewed-by: Sibi Sankar <quic_sibis@...cinc.com>
>> ---
> Thank you for your patch. There is something to discuss/improve.
>
>> @@ -543,6 +549,17 @@ static int adsp_init_mmio(struct qcom_adsp *adsp,
>>   		return PTR_ERR(adsp->qdsp6ss_base);
>>   	}
>>   
>> +	efuse_region = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> +	if (!efuse_region) {
>> +		adsp->lpass_efuse = NULL;
>> +		dev_dbg(adsp->dev, "failed to get efuse memory region\n");
>> +	} else {
> This needs bindings updates in all users.

Actually this is being used in SC7280 platform only. I am not sure if it 
applicable for other platforms.

If required, it can be posted as new series after this series got main 
lined.

>
> Best regards,
> Krzysztof
>