linux-kernel - Re: [PATCH] sched/psi: Use task->psi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzL89wKVbIn8y/QF@cmpxchg.org>
Date:   Tue, 27 Sep 2022 09:39:03 -0400
From:   Johannes Weiner <hannes@...xchg.org>
To:     Chengming Zhou <zhouchengming@...edance.com>
Cc:     surenb@...gle.com, mingo@...hat.com, peterz@...radead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/psi: Use task->psi_flags to clear in CPU migration

On Mon, Sep 26, 2022 at 04:19:31PM +0800, Chengming Zhou wrote:
> The commit d583d360a620 ("psi: Fix psi state corruption when schedule()
> races with cgroup move") fixed a race problem by making cgroup_move_task()
> use task->psi_flags instead of looking at the scheduler state.
> 
> We can extend task->psi_flags usage to CPU migration, which should be
> a minor optimization for performance and code simplicity.
> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>

Nice one!

Acked-by: Johannes Weiner <hannes@...xchg.org>