linux-kernel - Re: [PATCH v2 1/1] usb: typec: ucsi: Don't warn on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <PH0PR12MB5500D3A1DF88B8EA531DE165AF559@PH0PR12MB5500.namprd12.prod.outlook.com>
Date:   Tue, 27 Sep 2022 13:43:13 +0000
From:   Wayne Chang <waynec@...dia.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
        "quic_linyyuan@...cinc.com" <quic_linyyuan@...cinc.com>,
        "quic_jackp@...cinc.com" <quic_jackp@...cinc.com>,
        "saranya.gopal@...el.com" <saranya.gopal@...el.com>,
        "tiwai@...e.de" <tiwai@...e.de>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] usb: typec: ucsi: Don't warn on probe deferral

Hi Greg,

Thanks for the review.

On 9/27/22 20:40, Greg KH wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Tue, Sep 27, 2022 at 08:29:13PM +0800, Wayne Chang wrote:
>> Deferred probe is an expected return value for fwnode_usb_role_switch_get().
>> Given that the driver deals with it properly, there's no need to output a
>> warning that may potentially confuse users.
>>
>> Fixes: 3c162511530c ("usb: typec: ucsi: Wait for the USB role switches")
>> Cc: stable@...r.kernel.org
> 
> Why is this a bugfix that needs to be backported?  The current code
> works the same as what you are changing it to be, there's no functional
> difference, right?
> 
> thanks,
> 
> greg k-h
> 

Yes, there's no functional difference but clears probe deferral warnings.
I'll send v3 to remove them.

thanks,
Wayne.