linux-kernel - Re: [PATCH] ALSA: hda/hdmi: run eld notify in delay work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ill8gb5c.wl-tiwai@suse.de>
Date:   Tue, 27 Sep 2022 16:11:27 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Brent Lu <brent.lu@...el.com>
Cc:     alsa-devel@...a-project.org, Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Mohan Kumar <mkumard@...dia.com>,
        Ville Syrjälä 
        <ville.syrjala@...ux.intel.com>, Yong Zhi <yong.zhi@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/hdmi: run eld notify in delay work

On Tue, 27 Sep 2022 15:58:07 +0200,
Brent Lu wrote:
> 
> During resolution change, display driver would disable HDMI audio then
> enable it in a short time. There is possibility that eld notify for
> HDMI audio enable is called when previous runtime suspend is still
> running. In this case, the elf nofity just returns and not updating the
> status of corresponding HDMI pin/port. Here we move the eld nofity to
> a delay work so we don't lose it.
> 
> Signed-off-by: Brent Lu <brent.lu@...el.com>

We have already a dedicated per-pin work for the delayed ELD check.
Can we reuse it instead of inventing yet another work?
More work needs more cares, and better to avoid unless really needed
(e.g. you forgot cleanup at suspend/removal in this patch).


thanks,

Takashi