linux-kernel - Re: [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzMGbUQz4YPM5diz@google.com>
Date:   Tue, 27 Sep 2022 07:19:25 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>
Cc:     linux-input@...r.kernel.org,
        Robin van der Gracht <robin@...tonic.nl>,
        linux-kernel@...r.kernel.org, kernel@...i.sm,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, stable@...r.kernel.org,
        Martin Kepplinger <martin.kepplinger@...i.sm>
Subject: Re: [PATCH v2 RESEND] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1
 register address

On Tue, Sep 27, 2022 at 08:25:12AM +0200, Sebastian Krzyszkowiak wrote:
> Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
> (chapters 57.9 and 6.4.5 respectively).
> 
> Without this, trying to read the revision number results in 0 on
> all revisions, causing the i.MX6 quirk to apply on all platforms,
> which in turn causes the driver to synthesise power button release
> events instead of passing the real one as they happen even on
> platforms like i.MX8 where that's not wanted.
> 
> Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6 S, DL and Q")
> Cc: <stable@...r.kernel.org>
> Tested-by: Martin Kepplinger <martin.kepplinger@...i.sm>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>

Applied, thank you.

-- 
Dmitry