linux-kernel - Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d61596b-876b-2eca-f72d-ed38cc36f1a8@microchip.com>
Date:   Wed, 28 Sep 2022 15:35:48 +0000
From:   <Sergiu.Moga@...rochip.com>
To:     <lee@...nel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Claudiu.Beznea@...rochip.com>, <radu_nicolae.pirea@....ro>,
        <richard.genoud@...il.com>, <gregkh@...uxfoundation.org>,
        <jirislaby@...nel.org>, <Kavyasree.Kotagiri@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-spi@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI
 child node ref binding

On 28.09.2022 18:23, Lee Jones wrote:
> On Wed, 28 Sep 2022, Sergiu.Moga@...rochip.com wrote:
> 
>> On 28.09.2022 18:03, Lee Jones wrote:
>>> On Thu, 22 Sep 2022, Sergiu Moga wrote:
>>>
>>>> Another functionality of FLEXCOM is that of SPI. In order for
>>>> the proper validation of the SPI children nodes through the binding
>>>> to occur, the proper binding for SPI must be referenced.
>>>>
>>>> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>>> ---
>>>>
>>>>
>>>> v1 -> v2:
>>>> - use full schema paths
>>>>
>>>>
>>>> v2 -> v3:
>>>> - Added Reviewed-by tag, previously this was [PATCH 3]
>>>>
>>>>
>>>> v3 -> v4:
>>>> - Nothing, previously this was [PATCH 5]
>>>>
>>>>
>>>> v4 -> v5:
>>>> - Nothing
>>>>
>>>>
>>>>
>>>>    .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml       | 5 ++---
>>>>    1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> Not sure how these can be handled.
>>>
>>> I guess I cannot take these until the other patches are applied.
>>>
>>> NB: The patch doesn't apply cleanly anyway, so will need to be rebased.
>>>
>>
>>
>> Hello,
>>
>> The sama5d2-flexcom binding related patches are dependent on:
>> https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/
> 
> I would be very cautious about relying on comments made in the
> cover-letter.  Better to make this a hard requirement and place them
> in the same patch-set.
> 
> --
> Lee Jones [李琼斯]



Understood, my apologies, I will keep this in mind the next time this 
happens :).

Otherwise, by applying the patch series linked above, my sama5d2-flexcom 
patches should apply cleanly afterwards.

Thanks,
	Sergiu