linux-kernel - Re: [PATCH v2 1/2] dmaengine: idxd: Set wq state to disabled in idxd_wq_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77b8714b-aa3f-3866-72a2-e706428d2657@intel.com>
Date:   Wed, 28 Sep 2022 08:54:53 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>,
        linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org
Cc:     Fenghua Yu <fenghua.yu@...el.com>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v2 1/2] dmaengine: idxd: Set wq state to disabled in
 idxd_wq_disable_cleanup()


On 9/28/2022 8:48 AM, Jerry Snitselaar wrote:
> If we are calling idxd_wq_disable_cleanup(), the workqueue should be
> in a disabled state. So set the workqueue state to IDXD_WQ_DISABLED so
> that the state reflects that. Currently if there is a device failure,
> and a software reset is attempted the workqueues will not be
> re-enabled due to idxd_wq_enable() seeing that state as already being
> IDXD_WQ_ENABLED.
>
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Cc: Dave Jiang <dave.jiang@...el.com>
> Cc: Vinod Koul <vkoul@...nel.org>
> Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>

Reviewed-by: Dave Jiang <dave.jiang@...el.com>


> ---
>   drivers/dma/idxd/device.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> index 5a8cc52c1abf..31911e255ac1 100644
> --- a/drivers/dma/idxd/device.c
> +++ b/drivers/dma/idxd/device.c
> @@ -258,7 +258,6 @@ void idxd_wq_reset(struct idxd_wq *wq)
>   	operand = BIT(wq->id % 16) | ((wq->id / 16) << 16);
>   	idxd_cmd_exec(idxd, IDXD_CMD_RESET_WQ, operand, NULL);
>   	idxd_wq_disable_cleanup(wq);
> -	wq->state = IDXD_WQ_DISABLED;
>   }
>   
>   int idxd_wq_map_portal(struct idxd_wq *wq)
> @@ -378,6 +377,7 @@ static void idxd_wq_disable_cleanup(struct idxd_wq *wq)
>   	struct idxd_device *idxd = wq->idxd;
>   
>   	lockdep_assert_held(&wq->wq_lock);
> +	wq->state = IDXD_WQ_DISABLED;
>   	memset(wq->wqcfg, 0, idxd->wqcfg_size);
>   	wq->type = IDXD_WQT_NONE;
>   	wq->threshold = 0;