linux-kernel - Re: [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzRvEPUWUXP4x7+h@pendragon.ideasonboard.com>
Date:   Wed, 28 Sep 2022 18:58:08 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Michal Simek <michal.simek@...inx.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-gpio@...r.kernel.org,
        git@...inx.com, saikrishna12468@...il.com
Subject: Re: [PATCH 0/4] pinctrl: pinctrl-zynqmp: Add tri-state configuration
 support

Hi Sai,

On Fri, Jun 17, 2022 at 04:16:55PM +0530, Sai Krishna Potthuri wrote:
> This series update the Xilinx firmware, ZynqMP dt-binding and ZynqMP
> pinctrl driver to handle 'output-enable' and 'bias-high-impedance'
> configurations. As part of these configurations, ZynqMP pinctrl driver
> takes care of pin tri-state setting.
> Also fix the kernel doc warning in ZynqMP pinctrl driver.

I'm afraid this causes a regression :-( With this series applied, boot
breaks with the following message being printed to the serial console:

Received exception
MSR: 0x200, EAR: 0xFF180198, EDR: 0x0, ESR: 0x64

I've traced that to the probe of the UART, when it calls into the
firmware to set pin MIO18 to high impedance. According to v1.7 of the
ZynqMP registers reference (UG1087), there is no register at address
0xFF180198.

I am using the VCU TRD 2021.1 for testing. Does this series require a
firmware update ? If so backward compatibility needs to be preserved.
It's very late in the v6.0-rc cycle for a fix, a revert may be best at
this point, to give us time to fix the issue properly.

> Note: Resending the series as i see this series didn't went out due
> to some issue with my mail client. Please ignore if this series is 
> already received.
> 
> Sai Krishna Potthuri (4):
>   firmware: xilinx: Add configuration values for tri-state
>   dt-bindings: pinctrl-zynqmp: Add output-enable configuration
>   pinctrl: pinctrl-zynqmp: Add support for output-enable and
>     bias-high-impedance
>   pinctrl: pinctrl-zynqmp: Fix kernel-doc warning
> 
>  .../bindings/pinctrl/xlnx,zynqmp-pinctrl.yaml         |  4 ++++
>  drivers/pinctrl/pinctrl-zynqmp.c                      | 11 +++++++++++
>  include/linux/firmware/xlnx-zynqmp.h                  |  5 +++++
>  3 files changed, 20 insertions(+)

-- 
Regards,

Laurent Pinchart