linux-kernel - Re: linux-next: Tree for Sep 27 (uml 64-bit or 32-bit: tinyconfig)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae367f0e-424c-d026-23fb-5eafec93cfb1@infradead.org>
Date:   Tue, 27 Sep 2022 20:27:13 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     paulmck@...nel.org
Cc:     broonie@...nel.org,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-um <linux-um@...ts.infradead.org>
Subject: Re: linux-next: Tree for Sep 27 (uml 64-bit or 32-bit: tinyconfig)

Hi Paul,

On 9/27/22 15:42, Paul E. McKenney wrote:
> On Tue, Sep 27, 2022 at 02:33:19PM -0700, Randy Dunlap wrote:
>>
>>
>> On 9/27/22 14:28, Paul E. McKenney wrote:
>>> On Tue, Sep 27, 2022 at 02:13:29PM -0700, Randy Dunlap wrote:
>>>>
>>>>
>>>> On 9/27/22 13:10, broonie@...nel.org wrote:
>>>>> Hi all,
>>>>>
>>>>> Changes since 20220923:
>>>>>
>>>>
>>>> In file included from ../include/linux/notifier.h:16,
>>>>                  from ../include/linux/memory_hotplug.h:7,
>>>>                  from ../include/linux/mmzone.h:1244,
>>>>                  from ../include/linux/gfp.h:7,
>>>>                  from ../include/linux/slab.h:15,
>>>>                  from ../include/linux/crypto.h:20,
>>>>                  from ../arch/x86/um/shared/sysdep/kernel-offsets.h:5,
>>>>                  from ../arch/um/kernel/asm-offsets.c:1:
>>>> ../include/linux/srcu.h: In function ‘srcu_read_lock_nmisafe’:
>>>> ../include/linux/srcu.h:181:26: error: implicit declaration of function ‘__srcu_read_lock_nmisafe’; did you mean ‘srcu_read_lock_nmisafe’? [-Werror=implicit-function-declaration]
>>>>   181 |                 retval = __srcu_read_lock_nmisafe(ssp, true);
>>>>       |                          ^~~~~~~~~~~~~~~~~~~~~~~~
>>>>       |                          srcu_read_lock_nmisafe
>>>> ../include/linux/srcu.h: In function ‘srcu_read_unlock_nmisafe’:
>>>> ../include/linux/srcu.h:226:17: error: implicit declaration of function ‘__srcu_read_unlock_nmisafe’; did you mean ‘srcu_read_unlock_nmisafe’? [-Werror=implicit-function-declaration]
>>>>   226 |                 __srcu_read_unlock_nmisafe(ssp, idx, true);
>>>>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
>>>>       |                 srcu_read_unlock_nmisafe
>>>
>>> Could you please send your .config or tell me how you generated it?
>>
>>
>> For x86_64 SUBARCH, ARCH=um:
>>
>> mkdir UML64
>> make ARCH=um SUBARCH=x86_64 O=UML64 tinyconfig
>> make ARCH=um SUBARCH=x86_64 O=UML64 all
> 
> Thank you!  The diff shown below clears it up for me.  Does it cover it
> for you as well?

Works for me. Thanks.
Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested

> ------------------------------------------------------------------------
> 
> diff --git a/include/linux/srcu.h b/include/linux/srcu.h
> index 274d7200ce4e..565f60d57484 100644
> --- a/include/linux/srcu.h
> +++ b/include/linux/srcu.h
> @@ -52,6 +52,8 @@ int init_srcu_struct(struct srcu_struct *ssp);
>  #else
>  /* Dummy definition for things like notifiers.  Actual use gets link error. */
>  struct srcu_struct { };
> +int __srcu_read_lock_nmisafe(struct srcu_struct *ssp, bool chknmisafe) __acquires(ssp);
> +void __srcu_read_unlock_nmisafe(struct srcu_struct *ssp, int idx, bool chknmisafe) __releases(ssp);
>  #endif
>  
>  void call_srcu(struct srcu_struct *ssp, struct rcu_head *head,

-- 
~Randy