lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Sep 2022 00:09:52 +0200 From: Armin Wolf <W_Armin@....de> To: hdegoede@...hat.com, markgross@...nel.org Cc: andriy.shevchenko@...el.com, rafael@...nel.org, lenb@...nel.org, hmh@....eng.br, matan@...alib.org, corentin.chary@...il.com, jeremy@...tem76.com, productdev@...tem76.com, mario.limonciello@....com, pobrn@...tonmail.com, coproscefalo@...il.com, platform-driver-x86@...r.kernel.org, linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH] platform/x86: dell: Minor style fixes Fix some style issues found during review to improve code maintainability, no functional changes. Tested on a Dell Inspiron 3505. Signed-off-by: Armin Wolf <W_Armin@....de> --- drivers/platform/x86/dell/dell-wmi-ddv.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/dell/dell-wmi-ddv.c b/drivers/platform/x86/dell/dell-wmi-ddv.c index 6ccce90f475d..699feae3c435 100644 --- a/drivers/platform/x86/dell/dell-wmi-ddv.c +++ b/drivers/platform/x86/dell/dell-wmi-ddv.c @@ -1,13 +1,12 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* - * dell-wmi-ddv.c -- Linux driver for WMI sensor information on Dell notebooks. + * Linux driver for WMI sensor information on Dell notebooks. * * Copyright (C) 2022 Armin Wolf <W_Armin@....de> */ #define pr_format(fmt) KBUILD_MODNAME ": " fmt -#include <acpi/battery.h> #include <linux/acpi.h> #include <linux/debugfs.h> #include <linux/device.h> @@ -21,6 +20,8 @@ #include <linux/sysfs.h> #include <linux/wmi.h> +#include <acpi/battery.h> + #define DRIVER_NAME "dell-wmi-ddv" #define DELL_DDV_SUPPORTED_INTERFACE 2 @@ -52,7 +53,8 @@ enum dell_ddv_method { struct dell_wmi_ddv_data { struct acpi_battery_hook hook; - struct device_attribute temp_attr, eppid_attr; + struct device_attribute temp_attr; + struct device_attribute eppid_attr; struct wmi_device *wdev; }; @@ -153,8 +155,9 @@ static int dell_wmi_ddv_query_string(struct wmi_device *wdev, enum dell_ddv_meth static int dell_wmi_ddv_battery_index(struct acpi_device *acpi_dev, u32 *index) { - const char *uid_str = acpi_device_uid(acpi_dev); + const char *uid_str; + uid_str = acpi_device_uid(acpi_dev); if (!uid_str) return -ENODEV; -- 2.30.2
Powered by blists - more mailing lists