linux-kernel - Re: [PATCH linux-next] net: atm: Convert to use sysfs_emit()/sysfs_emit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8101cb98ab2993bf24720507be13f8d54233a161.camel@perches.com>
Date:   Wed, 28 Sep 2022 16:00:02 -0700
From:   Joe Perches <joe@...ches.com>
To:     Jakub Kicinski <kuba@...nel.org>, zhangsongyi.cgel@...il.com
Cc:     davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
        zhang.songyi@....com.cn, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux-next] net: atm: Convert to use
 sysfs_emit()/sysfs_emit_at() APIs

On Tue, 2022-09-27 at 07:01 -0700, Jakub Kicinski wrote:
> On Tue, 27 Sep 2022 06:46:49 +0000 zhangsongyi.cgel@...il.com wrote:
> > From: zhang songyi <zhang.songyi@....com.cn>
> > 
> > Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> > should only use sysfs_emit() or sysfs_emit_at() when formatting the value
> > to be returned to user space.
> 
> Is there an end goal to this?

To make it easier to validate all other kernel uses of
sprintf/snprintf/scnprintf.

> If the code is correct let's leave 
> it as is. ATM is hopefully going to be deleted soon.

<shrug>  The code is correct as-is.