linux-kernel - Re: [PATCH] of: Fix "dma-ranges" handling for bus controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 13:30:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Robin Murphy <robin.murphy@....com>, robh+dt@...nel.org,
        frowand.list@...il.com
Cc:     kbuild-all@...ts.01.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>
Subject: Re: [PATCH] of: Fix "dma-ranges" handling for bus controllers

Hi Robin,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.0-rc7 next-20220927]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Robin-Murphy/of-Fix-dma-ranges-handling-for-bus-controllers/20220927-190806
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/fd09e551a6765fd2ac8d16595f436ba95284cdf6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Robin-Murphy/of-Fix-dma-ranges-handling-for-bus-controllers/20220927-190806
        git checkout fd09e551a6765fd2ac8d16595f436ba95284cdf6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/of/address.c:582:21: error: redefinition of '__of_get_dma_parent'
     582 | struct device_node *__of_get_dma_parent(const struct device_node *np)
         |                     ^~~~~~~~~~~~~~~~~~~
   In file included from drivers/of/address.c:18:
   drivers/of/of_private.h:165:35: note: previous definition of '__of_get_dma_parent' with type 'struct device_node *(const struct device_node *)'
     165 | static inline struct device_node *__of_get_dma_parent(const struct device_node *np)
         |                                   ^~~~~~~~~~~~~~~~~~~


vim +/__of_get_dma_parent +582 drivers/of/address.c

   581	
 > 582	struct device_node *__of_get_dma_parent(const struct device_node *np)
   583	{
   584		struct of_phandle_args args;
   585		int ret, index;
   586	
   587		index = of_property_match_string(np, "interconnect-names", "dma-mem");
   588		if (index < 0)
   589			return of_get_parent(np);
   590	
   591		ret = of_parse_phandle_with_args(np, "interconnects",
   592						 "#interconnect-cells",
   593						 index, &args);
   594		if (ret < 0)
   595			return of_get_parent(np);
   596	
   597		return of_node_get(args.np);
   598	}
   599	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (241706 bytes)