linux-kernel - Re: [Intel-gfx] [PATCH v12 3/9] overflow: Introduce overflows_type() and __castable_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202209281418.lZIjIe4J-lkp@intel.com>
Date:   Wed, 28 Sep 2022 14:21:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>,
        intel-gfx@...ts.freedesktop.org
Cc:     kbuild-all@...ts.01.org, gustavoars@...nel.org, trix@...hat.com,
        dlatypov@...gle.com, llvm@...ts.linux.dev,
        linux@...musvillemoes.dk, dri-devel@...ts.freedesktop.org,
        chris@...is-wilson.co.uk, linux-hardening@...r.kernel.org,
        andrzej.hajda@...el.com, linux-sparse@...r.kernel.org,
        matthew.auld@...el.com, airlied@...hat.com,
        thomas.hellstrom@...ux.intel.com, keescook@...omium.org,
        jani.nikula@...el.com, nathan@...nel.org, mchehab@...nel.org,
        ndesaulniers@...gle.com, linux-kernel@...r.kernel.org,
        daniel@...ll.ch, vitor@...saru.org, luc.vanoostenryck@...il.com,
        nirmoy.das@...el.com
Subject: Re: [Intel-gfx] [PATCH v12 3/9] overflow: Introduce overflows_type()
 and __castable_to_type()

Hi Gwan-gyeong,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v6.0-rc7]
[cannot apply to drm-intel/for-linux-next kees/for-next/hardening next-20220927]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Gwan-gyeong-Mun/Fixes-integer-overflow-or-integer-truncation-issues-in-page-lookups-ttm-place-configuration-and-scatterlist-creation/20220927-094859
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-rhel-8.3-kunit
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/49eb3d58d93b3ac457ea8de8879e19e55c2788e6
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Gwan-gyeong-Mun/Fixes-integer-overflow-or-integer-truncation-issues-in-page-lookups-ttm-place-configuration-and-scatterlist-creation/20220927-094859
        git checkout 49eb3d58d93b3ac457ea8de8879e19e55c2788e6
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash lib/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   lib/overflow_kunit.c:20: warning: ignoring '#pragma clang diagnostic' [-Wunknown-pragmas]
      20 | #pragma clang diagnostic ignored "-Wtautological-constant-out-of-range-compare"
         | 
   lib/overflow_kunit.c: In function 'castable_to_type_test':
>> lib/overflow_kunit.c:984:13: warning: unused variable 'small' [-Wunused-variable]
     984 |         s64 small;
         |             ^~~~~
>> lib/overflow_kunit.c:983:13: warning: unused variable 'big' [-Wunused-variable]
     983 |         u64 big;
         |             ^~~


vim +/small +984 lib/overflow_kunit.c

   979	
   980	static void castable_to_type_test(struct kunit *test)
   981	{
   982	#if BITS_PER_LONG == 64
 > 983		u64 big;
 > 984		s64 small;
   985	#else
   986		u32 big;
   987		s32 small;
   988	#endif
   989		int count = 0;
   990	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (165116 bytes)