linux-kernel - Re: [PATCH v3 1/1] usb: typec: ucsi: Don't warn on probe deferral

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzPocs9hMZBuQ3Pp@kuha.fi.intel.com>
Date:   Wed, 28 Sep 2022 09:23:46 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Wayne Chang <waynec@...dia.com>
Cc:     gregkh@...uxfoundation.org, quic_linyyuan@...cinc.com,
        quic_jackp@...cinc.com, saranya.gopal@...el.com, tiwai@...e.de,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/1] usb: typec: ucsi: Don't warn on probe deferral

On Tue, Sep 27, 2022 at 09:45:12PM +0800, Wayne Chang wrote:
> Deferred probe is an expected return value for fwnode_usb_role_switch_get().
> Given that the driver deals with it properly, there's no need to output a
> warning that may potentially confuse users.
> 
> Signed-off-by: Wayne Chang <waynec@...dia.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> --
> V2 -> V3: remove the Fixes and Cc
> V1 -> V2: adjust the coding style for better reading format.
>  drivers/usb/typec/ucsi/ucsi.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c
> index 7f2624f42724..e961ebecd7df 100644
> --- a/drivers/usb/typec/ucsi/ucsi.c
> +++ b/drivers/usb/typec/ucsi/ucsi.c
> @@ -1069,11 +1069,9 @@ static int ucsi_register_port(struct ucsi *ucsi, int index)
>  
>  	cap->fwnode = ucsi_find_fwnode(con);
>  	con->usb_role_sw = fwnode_usb_role_switch_get(cap->fwnode);
> -	if (IS_ERR(con->usb_role_sw)) {
> -		dev_err(ucsi->dev, "con%d: failed to get usb role switch\n",
> -			con->num);
> -		return PTR_ERR(con->usb_role_sw);
> -	}
> +	if (IS_ERR(con->usb_role_sw))
> +		return dev_err_probe(ucsi->dev, PTR_ERR(con->usb_role_sw),
> +			"con%d: failed to get usb role switch\n", con->num);
>  
>  	/* Delay other interactions with the con until registration is complete */
>  	mutex_lock(&con->lock);

thanks,

-- 
heikki