linux-kernel - Re: [PATCH] usb: dwc3: st: Fix node's child name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <552281f4-dc8c-7cd7-32af-fa48de5aa414@foss.st.com>
Date:   Wed, 28 Sep 2022 08:45:54 +0200
From:   Patrice CHOTARD <patrice.chotard@...s.st.com>
To:     Felipe Balbi <felipe@...bi.sh>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Jerome Audu <jerome.audu@...com>
Subject: Re: [PATCH] usb: dwc3: st: Fix node's child name

Hi Felipe, Krzysztof

On 9/27/22 17:15, Felipe Balbi wrote:
> 
> <patrice.chotard@...s.st.com> writes:
> 
>> From: Patrice Chotard <patrice.chotard@...s.st.com>
>>
>> Update node's child name from "dwc3" to "usb", this fixes
>> the following issue:
>>
>> [3.773852] usb-st-dwc3 8f94000.dwc3: failed to find dwc3 core node
>>
>> Fixes: 3120910a099b ("ARM: dts: stih407-family: Harmonize DWC USB3 DT nodes name")
>>
>> Reported-by: Jerome Audu <jerome.audu@...com>
>> Signed-off-by: Patrice Chotard <patrice.chotard@...s.st.com>
>> ---
>>  drivers/usb/dwc3/dwc3-st.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
>> index 166b5bde45cb..6c14a79279f9 100644
>> --- a/drivers/usb/dwc3/dwc3-st.c
>> +++ b/drivers/usb/dwc3/dwc3-st.c
>> @@ -251,7 +251,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
>>  	/* Manage SoftReset */
>>  	reset_control_deassert(dwc3_data->rstc_rst);
>>  
>> -	child = of_get_child_by_name(node, "dwc3");
>> +	child = of_get_child_by_name(node, "usb");
> 
> there could be DTBs in the wild which have `dwc3' as the child name. It
> seems to me that you should try both names, instead.
> 

As this patch is already merged, i will submit an additional patch which will 
rely on child's compatible string instead of child's node name, as done in other
dwc3 driver.

Thanks
Patrice