lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Sep 2022 08:58:50 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>, linux-remoteproc@...r.kernel.org, agross@...nel.org, andersson@...nel.org, lgirdwood@...il.com, broonie@...nel.org, robh+dt@...nel.org, quic_plai@...cinc.com, bgoswami@...cinc.com, perex@...ex.cz, tiwai@...e.com, srinivas.kandagatla@...aro.org, quic_rohkumar@...cinc.com, linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org, swboyd@...omium.org, judyhsiao@...omium.org, devicetree@...r.kernel.org Subject: Re: [PATCH v9 1/7] dt-bindings: remoteproc: qcom: Add SC7280 ADSP support On 27/09/2022 15:56, Srinivasa Rao Mandadapu wrote: > Add ADSP PIL loading support for SC7280 SoCs. > > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com> > Reviewed-by: Rob Herring <robh@...nel.org> > Reviewed-by: Stephen Boyd <swboyd@...omium.org> > --- Thank you for your patch. There is something to discuss/improve. > + qcom,smem-state-names: > + description: The names of the state bits used for SMP2P output > + const: stop > + > + qcom,qmp: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: Reference to the AOSS side-channel message RAM. > + > + glink-edge: > + $ref: qcom,glink-edge.yaml# > + type: object You still miss here unevaluatedProperties: false on this level of indentation. > + description: | > + Qualcomm G-Link subnode which represents communication edge, channels > + and devices related to the ADSP. > + Best regards, Krzysztof
Powered by blists - more mailing lists