linux-kernel - Re: [PATCH v6 2/5] Input: joystick: xpad: Add X-Box Adaptive XBox button

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfkcezg7.fsf@mkorpershoek-xps-13-9370.home>
Date:   Wed, 28 Sep 2022 09:21:44 +0200
From:   Mattijs Korpershoek <mkorpershoek@...libre.com>
To:     Nate Yocom <nate@...om.org>, dmitry.torokhov@...il.com
Cc:     nate@...om.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, hadess@...ess.net,
        benjamin.tissoires@...hat.com
Subject: Re: [PATCH v6 2/5] Input: joystick: xpad: Add X-Box Adaptive XBox
 button

Hi Nate,

On Thu, Sep 08, 2022 at 10:39, Nate Yocom <nate@...om.org> wrote:

> Adaptive controller sets 0x02 bit for this button, all others set 0x01
> so presence of either is used for BTN_MODE.
>
> Signed-off-by: Nate Yocom <nate@...om.org>
> Tested-by: Bastien Nocera <hadess@...ess.net>

This does not applies properly anymore on dtor/next [1] because of
90c9978959da ("Input: xpad - refactor using BIT() macro") and
e23c69e33248 ("Input: xpad - add support for XBOX One Elite paddles")

With that, please add:

Reviewed-by: Mattijs Korpershoek <mkorpershoek@...libre.com

> ---
>  drivers/input/joystick/xpad.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index c8b38bb73d34..dff0d099d416 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -858,7 +858,7 @@ static void xpadone_process_packet(struct usb_xpad *xpad, u16 cmd, unsigned char
>  		if (data[1] == 0x30)
>  			xpadone_ack_mode_report(xpad, data[2]);
>  
> -		input_report_key(dev, BTN_MODE, data[4] & 0x01);
> +		input_report_key(dev, BTN_MODE, data[4] & 0x03);
>  		input_sync(dev);
>  		return;
>  	}
> -- 
> 2.30.2