linux-kernel - Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfcc8d22-8efd-8b0b-d24f-cb734f9ef927@linux.ibm.com>
Date:   Wed, 28 Sep 2022 10:24:29 +0200
From:   Alexandra Winter <wintera@...ux.ibm.com>
To:     Joe Perches <joe@...ches.com>, Jules Irenge <jbi.octave@...il.com>,
        borntraeger@...ux.ibm.com
Cc:     svens@...ux.ibm.com, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        agordeev@...ux.ibm.com
Subject: Re: [PATCH 3/7] s390/qeth: Convert snprintf() to scnprintf()



On 27.09.22 16:27, Joe Perches wrote:
> On Mon, 2022-09-26 at 19:42 +0100, Jules Irenge wrote:
>> Coccinnelle reports a warning
>> Warning: Use scnprintf or sprintf
>> Adding to that, there has been a slow migration from snprintf to scnprintf.
>> This LWN article explains the rationale for this change
>> https: //lwn.net/Articles/69419/
>> Ie. snprintf() returns what *would* be the resulting length,
>> while scnprintf() returns the actual length.
> []
>> diff --git a/drivers/s390/net/qeth_core_sys.c b/drivers/s390/net/qeth_core_sys.c
> []
>> @@ -500,9 +500,9 @@ static ssize_t qeth_hw_trap_show(struct device *dev,
>>  	struct qeth_card *card = dev_get_drvdata(dev);
>>  
>>  	if (card->info.hwtrap)
>> -		return snprintf(buf, 5, "arm\n");
>> +		return scnprintf(buf, 5, "arm\n");
>>  	else
>> -		return snprintf(buf, 8, "disarm\n");
>> +		return scnprintf(buf, 8, "disarm\n");
>>  }
> 
> Use sysfs_emit instead.
> 

Thank you Joe, that sounds like the best way to handle this. 
I propose that I take this onto my ToDo list and test it in the s390 environment.
I will add 
Reported-by: Jules Irenge <jbi.octave@...il.com>
Suggested-by: Joe Perches <joe@...ches.com>